Repository navigation
fix(android): make the android tree usable from non-Windows clones - #134
Merged
Merged
Conversation
added 3 commits
October 10, 2026 16:47
`git ls-files -s android/gradlew` reports 100644 while android/gradlew.bat is 100755: the android subtree was authored on Windows, where core.fileMode is off, so the POSIX launcher shipped without its mode. README 1.3 tells every reader to run `./gradlew :app:assembleDebug`, and on Linux/macOS that dies with "permission denied" (rc=126) before Gradle even starts. The bit is set in the index, not just on disk - chmod alone leaves the next clone broken. The repo already tracks modes elsewhere (ios/scripts/test.sh, macos/scripts/*.sh, python/scripts/fetch_models.py are all 100755), so this is a missing bit rather than a policy change.
build_vendor_libs.sh derives the monorepo root with `pwd -W`, which only
exists in Git-Bash. On Linux/macOS the builtin rejects -W, the command
substitution returns non-zero, and `set -euo pipefail` aborts at the depot
line - silently, with no log output, which reads as a broken script rather
than a host-portability gap.
`{ pwd -W 2>/dev/null || pwd -P; }` leaves Git-Bash semantics untouched (the
-W form wins wherever it exists) and gives other POSIX hosts the resolved
path. EDGE0_DEPOT still overrides, but it is no longer required to be
exported: relying on a shell variable hides the regression from everyone
whose shell does not set it.
Verified on Linux with EDGE0_DEPOT unset: the depot root resolves and
vendor.llama.pin is visible from it.
`./gradlew :app:testDebugUnitTest` runs 32 tests here, not 26: counting @test under app/src/test gives 32 in this tree (and in the android source the release is cut from). The instrumented figure on the line above it is accurate - app/src/androidTest carries exactly 8 @test methods - so only the host-side number was stale. Fixed across all five language copies so they do not drift apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two host-portability breaks make
android/unbuildable from any Linux/macOS clone, andboth bite before a single line of project code runs:
android/gradlewis committed as mode 100644 whileandroid/gradlew.batis 100755.README 1.3 tells the reader to run
./gradlew :app:assembleDebug; on Linux/macOS that ispermission denied, exit code 126, with Gradle never starting.android/tools/llama/build_vendor_libs.shresolves the monorepo root withpwd -W, aGit-Bash (MSYS) only form. On other POSIX shells the builtin rejects
-W, the commandsubstitution returns non-zero, and
set -euo pipefailaborts at the depot line -silently, with no log output, so it reads as "the script is broken" rather than
"wrong host".
Changes
android/gradlewin the index, not just on disk: a localchmodleaves the next clone exactly as broken as this one. The repo already tracks modes
(
ios/scripts/test.sh,macos/scripts/*.sh,python/scripts/fetch_models.pyare all100755), so this is a missing bit rather than a policy change.
DEPOT=${EDGE0_DEPOT:-$(cd "$REPO/.." && { pwd -W 2>/dev/null || pwd -P; })}- Git-Bashsemantics untouched (the
-Wform wins wherever it exists), other hosts get the resolvedpath, and
EDGE0_DEPOTstill overrides but is no longer required to be exported.docs(android): host unit-test count26 -> 32in all five language copies.