docs(frame): clarify safe-area env injection - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safe-area-bottomanddeviceProfile.safeAreaInsets.bottomupdate the frame's metrics, CSS custom properties and rendering, but they do not change the browser's nativeenv(safe-area-inset-bottom)value. The previous documentation mentioned this limitation without showing which values do change or how separately hosted content should receive them.The English and Chinese frame READMEs now document the boundary with a concrete bottom-inset example. They also explain that Electron/Chromium hosts can inject native
env()values withEmulation.setSafeAreaInsetsOverride, while@devicekit/frameitself does not manage CDP sessions. The changelog records the clarification.Verified with
pnpm build,pnpm test(1,042 tests, 0 skipped),pnpm lint,pnpm check-types, andgit diff --check.