Repository navigation
Walk v2 snapshot history via repo file parent offsets - #28
Merged
Merged
Conversation
v2 snapshot files carry no parent pointer, so walkHistory stopped after the head snapshot on every v2 repo. Resolve parents from the repo file's parent_offset indices, reloading the repo info once when a snapshot is newer than the cached copy. Reject corrupt offsets and cyclic ancestry.
A snapshot absent from the cached repo info now throws rather than triggering a refetch, keeping the Repository's view fixed at open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
walkHistorystopped after the head snapshot on v2 repos. v2 snapshot files don't store a parent: that information lives only in the repo file asparent_offset. The walk now finds each parent there.Tests cover
mainand feature-branch histories plus the error cases.