Changes to CPLHIST mode for robustness and getting the right default settings for CLM and an updated 1850 ndep file - #403
Merged
Conversation
… directory location for the DATM_CPLHIST_CASE under cpl/hist subdirectory
ekluzek
added
answers are bfb
Responsibility: CTSM
Contributor
|
It's not clear to me if the intent of this PR + #405 are needed for:
|
Member
It's (1) - to be able to use CPLHIST output. |
Contributor
|
OK, if this is only needed for CTSM to read CPL_HIST data my read is that this PR isn't critical for the next alpha09 tag. What do others think? |
ekluzek
commented
Aug 18, 2026
cdeps1.0.105 Conflicts: datm/cime_config/config_component.xml
…w including important points about clm_usr_dat_name and available_neon_data
…and use it to define it, and also check that if one is set the other is as well, and then ensure single_column is set at the end of the subroutine
Member
|
@mvertens gave me the okay to move ahead with this without her re-review, once my review points are satisfied. It looks like all of her earlier review points have been accounted for. I don't know how to mark her earlier review as okay; the best I can see is re-requesting a review. But @mvertens you don't actually need to re-review this unless you want to. |
billsacks
dismissed
mvertens’s stale review
September 12, 2026 18:48
@mvertens gave me her okay to move ahead with this without a re-review from her.
…different for MOM and CLM, and for DATM testing there needs to be a default
…P, as there isn't a way to do that without an additional test mod, this was pointed out in the review
…version as that's the latest standard, the other was just to test different combinatorics with a different forcing option
…RA from code review
…quested in code review
…lm_usr_dat_name exists or not as caught in code reivew
…y list as pointed out in the review, also only print CLM_USRDAT_NAME if it's set, rather than all the time
… if GRID isn't CLM_USRDAT, also change some comments around that and fix an earlier syntax error
…e default UNSET when the grid isn't CLM_USRDAT
Collaborator
Author
|
OK, I think I've covered everything. I've sent off testing again, so we'll see how that goes in the morning light. It also looks like I need to update to the latest, and I'll resend the testing providing everything works as expected. |
Member
@ekluzek - no need to redo testing with an update to the latest - all you're missing is a tiny unrelated change, so if testing looks good on the current version, that's sufficient. |
billsacks
approved these changes
Sep 14, 2026
billsacks
left a comment
billsacks
left a comment
Member
There was a problem hiding this comment.
I have looked over all of the recent changes, and this all looks great to me. I'm happy with how you addressed all of my requests. Thank you very much for all of your work in iterating on this to get to this place!
Collaborator
Author
|
OK, testing went as expected. 1850 tests are different in the NDEP fields, because of the change to clim_1850_cesm3. |
Collaborator
Author
|
Here's the summary of the testing of aux_cdeps compared to cesm3_0_alpha10a. |
Collaborator
Author
|
OK, I've resolved all the conversations. So I'm merging, to have a tag for me to use. |
github-project-automation
Bot
moved this from In Progress
to Done
in LMWG: Sprint Planning Board
Collaborator
Author
|
Probably a day of time was done on this way back in April. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Work with 1850_clim settings for ndep. As well as some work with CPLHIST options.
Specific notes
Contributors other than yourself, if any: @billsacks
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial): No
This will add some new options, but won't change defaults (which primarily need to be changed in compsets anyway)
Any User Interface Changes (namelist or namelist defaults changes): Yes
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Have tested a few cases will test aux_cdeps against cesm3_0_beta08 tests
Hashes used for testing:
Definition of done: