Skip to content

Use full path in the zlib configuration option for PETSc for better logging - #300

Merged
boegel merged 2 commits into
EESSI:mainfrom
gkaf89:logging
Sep 4, 2026
Merged

Use full path in the zlib configuration option for PETSc for better logging#300
boegel merged 2 commits into
EESSI:mainfrom
gkaf89:logging

Conversation

@gkaf89

@gkaf89 gkaf89 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@boegel

boegel commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@gkaf89 I don't mind this change, but I do wonder why using ${EESSI_EPREFIX} was confusing?

@boegel boegel changed the title [STYLE] Use full path in the configuration command for better logging [STYLE] Use full path in the zlib configuration option for PETSc for better logging Sep 4, 2026
@gkaf89

gkaf89 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@boegel It's more for consistency, other output in stdout uses full paths and the then the PETCs hook prints a variable. If something goes wrong someone would have to check the value of ${EESSI_EPREFIX}, whereas with a full path the problem would be visible immediately.

It's really a minor issue.

@boegel

boegel commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Makes sense, also matches better with what we do in other hook pre_configure_hook_symengine already...

boegel
boegel approved these changes Sep 4, 2026
View reviewed changes

@boegel boegel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually, good to deploy & merge...

@boegel

boegel commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

bot: build repo:eessi.io-2023.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace
bot: build repo:eessi.io-2026.06-software instance:eessi-bot-jsc for:arch=aarch64/nvidia/grace

@eessi-bot-jsc

eessi-bot-jsc Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2023.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_300/15591944

date job status comment
Sep 04 11:56:25 UTC 2026 submitted job id 15591944 awaits release by job manager
Sep 04 11:57:17 UTC 2026 released job awaits launch by Slurm scheduler
Sep 04 12:02:33 UTC 2026 running job 15591944 is running
Sep 04 12:04:42 UTC 2026 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15591944.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2023.06-software-linux-aarch64-nvidia-grace-17885233990.tar.gzsize: 0 MiB (31512 bytes)
entries: 1
modules under 2023.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2023.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2023.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2023.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 04 12:04:42 UTC 2026 test result
😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15591944.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Sep 04 12:18:37 UTC 2026 uploaded transfer of eessi-2023.06-software-linux-aarch64-nvidia-grace-17885233990.tar.gz to S3 bucket succeeded

@eessi-bot-jsc

eessi-bot-jsc Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2025.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_300/15591946

date job status comment
Sep 04 11:56:30 UTC 2026 submitted job id 15591946 awaits release by job manager
Sep 04 11:57:13 UTC 2026 released job awaits launch by Slurm scheduler
Sep 04 12:04:40 UTC 2026 running job 15591946 is running
Sep 04 12:10:58 UTC 2026 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15591946.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2025.06-software-linux-aarch64-nvidia-grace-17885237910.tar.gzsize: 0 MiB (31511 bytes)
entries: 1
modules under 2025.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2025.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2025.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2025.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 04 12:10:58 UTC 2026 test result
😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15591946.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Sep 04 12:18:17 UTC 2026 uploaded transfer of eessi-2025.06-software-linux-aarch64-nvidia-grace-17885237910.tar.gz to S3 bucket succeeded

@eessi-bot-jsc

eessi-bot-jsc Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

New job on instance eessi-bot-jsc for repository eessi.io-2026.06-software
Building on: nvidia-grace
Building for: aarch64/nvidia/grace
Job dir: /p/project1/ceasybuilders/eessibot/jobs/2026.09/pr_300/15591947

date job status comment
Sep 04 11:56:35 UTC 2026 submitted job id 15591947 awaits release by job manager
Sep 04 11:57:10 UTC 2026 released job awaits launch by Slurm scheduler
Sep 04 11:58:21 UTC 2026 running job 15591947 is running
Sep 04 12:01:28 UTC 2026 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-15591947.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.* created!
Artefacts
eessi-2026.06-software-linux-aarch64-nvidia-grace-17885230860.tar.gzsize: 0 MiB (31515 bytes)
entries: 1
modules under 2026.06/software/linux/aarch64/nvidia/grace/modules/all
no module files in tarball
software under 2026.06/software/linux/aarch64/nvidia/grace/software
no software packages in tarball
reprod directories under 2026.06/software/linux/aarch64/nvidia/grace/reprod
no reprod directories in tarball
other under 2026.06/software/linux/aarch64/nvidia/grace
no other files in tarball
Sep 04 12:01:28 UTC 2026 test result
😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-15591947.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Sep 04 12:18:27 UTC 2026 uploaded transfer of eessi-2026.06-software-linux-aarch64-nvidia-grace-17885230860.tar.gz to S3 bucket succeeded

@boegel boegel changed the title [STYLE] Use full path in the zlib configuration option for PETSc for better logging Use full path in the zlib configuration option for PETSc for better logging Sep 4, 2026
@boegel

boegel commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

staging PR merged

@boegel
boegel merged commit 734949f into EESSI:main Sep 4, 2026
100 of 106 checks passed
@boegel boegel mentioned this pull request Sep 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bot:deploy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gkaf89 @boegel