Conversation
…nto a public storage.
… directory the app retains access to previously selected public directory.
# Conflicts: # app/src/main/java/com/dimowner/audiorecorder/v2/audio/MediaRecorderBase.kt # app/src/main/java/com/dimowner/audiorecorder/v2/data/PrefsV2Impl.kt # app/src/main/java/com/dimowner/audiorecorder/v2/di/AppModule.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for handling audio records stored in public directories selected by the user via the Android Storage Access Framework (SAF), which are referenced by
content://URIs. The changes ensure that decoding, playback, sharing, and metadata extraction work seamlessly for both traditional file paths and SAF-based URIs. Additionally, the update includes new tests and minor version increments.Support for SAF (Storage Access Framework) and content URIs:
AudioDecoderandAudioWaveformVisualizationto accept aContextand handle both file paths andcontent://URIs for decoding, including a new method to read audio metadata from URIs. [1] [2] [3] [4] [5]AudioPlayerNewto accept aContextand play audio fromcontent://URIs as well as file paths. [1] [2]File sharing improvements:
AndroidUtils.shareAudioFileandshareAudioFilesto share both file paths andcontent://URIs, ensuring compatibility with records stored in public directories. [1] [2]Test enhancements:
PrefsV2ImplTestandFileExtensionsTest. [1] [2]FileDataSourceImplTestto provide preferences when constructing the data source, reflecting the new constructor requirements.Minor version update:
versionCodeandversionNameinapp/build.gradle.ktsto950and2.4.1respectively.Decode service updates:
DecodeServiceto passapplicationContextwhen decoding, supporting both file paths and URIs. [1] [2]