Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Atomic Skill benchmark case construction and task scoring currently share a large scenario module, while raw cases have no explicit evaluation-domain identity. This draft establishes the first shared interfaces for #669 so embodiment/provider integration and physical evaluator work can proceed against one runner and artifact contract.
AtomicSkillCaseProviderintoatomic_skill.pyand expose the measuredExecutionObservationcontract. Preserve the existing provider import and legacytask_result()behavior.PhysicalStageEvaluatorinterface that receives case inputs, measured observations, and motion outcomes, without a compiled trajectory or projected context. Validate ordered stage states and complete per-environment coverage; retain stage evidence and failure attribution in raw trial outcomes. Physical success cannot override failed motion or execution.id,version,kind). Snapshot it onto cases and all associated lifecycle/trial records. Keep undeclared legacy domains unclassified and planner hashes separate from case content.Refs #669. This is the foundation PR, not completion of the issue.
Follow-up boundaries
Dependencies: no new packages; independent of merging #642.
Type of change
Validation
/home/dex/miniconda3/envs/open/bin/python -m pytest -q -rs tests/benchmark/motion_generation: 137 passed, 1 skipped. The existing GPU test requires--run-gpu; no live simulator/GPU replay was performed.black .using 26.3.1,black --check ., andgit diff --check: passed.python docs/scripts/check_api_docs.py: 2229/2229 exports documented.The default Python environment lacks simulator dependencies; the existing
openenvironment was used for the complete focused regression suite.Context review:
context.py affected --base origin/main --explainreports no affected topics. Changes are confined to benchmark scripts/tests; production simulation and Atomic Skill behavior are unchanged. The benchmark README documents the new contracts, so no agent-context revision was needed.Screenshots
Not applicable; this change adds benchmark interfaces and raw artifact fields.
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicable. No packaged public API changes.