Add impact-based partial CI test selection - #622
Open
yuecideng wants to merge 3 commits into
Open
Conversation
|
Cover the dataset functor consumer, diff pull requests from their merge base, and pin workflow actions to immutable revisions.
Run changed slow nodes in resource-specific lanes instead of promoting the whole PR to the complete slow suite. Align the process-wide DexSim worker setting with SimulationManagerCfg so contact outcomes and runtime remain stable in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR tests previously installed gensim and cuRobo on every run and collected the entire suite in each resource lane. This change builds an explainable test plan from the cumulative PR diff, selecting affected test files and contract checks for mapped changes while falling back to broader validation when impact cannot be established safely.
slow. Changed slow files get narrowslow-*lanes rather than promoting the entire PR to the complete slow suite. Nightly runs at 02:00 UTC and manualfullruns still cover every slow test.SimulationManagerCfg.cpu_num=1. The previous native automatic worker setting produced a different contact result in the scoop integration test; all three seeds pass after the fixture fix.Test gateresult. CI script changes no longer trigger an unrelated Sphinx build.Dependencies: Python 3.11 and pytest for planning, with optional PyYAML for MAP routing and a conservative manifest-only fallback. Runtime requirements are unchanged.
The first implementation selects test files rather than coverage-derived node IDs. Native code, resource/configuration dependencies, and dynamic consumers rely on explicit rules and full fallbacks. Source changes do not automatically promote every impacted slow node into PR validation; the complete slow matrix remains covered by nightly/manual full runs. Design and rollout details are in
design/ci-partial-test-selection.md.Type of change
Validation
python -m pytest -q tests/ci tests/docs --confcutdir=tests/docs), including mixed CPU/GPU slow files, parameter-level slow marks, unrelated GPU markers, slow-only lanes, docs-only slow tests, and full-mode boundaries.--run-gpu -m 'slow or not slow' --renderer fast-rt). Before the fixture change, the local physical cases failed with zero retained ice cubes.black==26.3.1formatting, actionlint on the workflow, Python compilation, manifest selector resolution, and context-map checks passed. Public API docs: 2067/2067 exports documented.The prior remote test job took about 108 minutes: dependency installation ~23 minutes, fast 13m35s, sim 45m19s, distributed 24s, and GPU 23m56s. It also waited about 108 minutes for a runner. Its
fullplan exposed the unrelated slow scoop failure. This PR's CI/fixture changes still selectfull-pr, with extra slow selectors limited to the changed NMS file. Actual overall runtime savings require the new remote run; dependency installation and runner queue time remain separate costs.Checklist
black .command to format the code base.