Skip to content

ci(desktop): fix unsigned macOS builds and Linux Electron sandbox - #89

Merged
venkateshsakamuri-lab merged 2 commits into
mainfrom
cursor/fix-desktop-release-ci-231a
Aug 28, 2026
Merged

ci(desktop): fix unsigned macOS builds and Linux Electron sandbox#89
venkateshsakamuri-lab merged 2 commits into
mainfrom
cursor/fix-desktop-release-ci-231a

Conversation

@venkateshsakamuri-lab

Copy link
Copy Markdown
Contributor

Summary

Fixes the desktop-v1.0.0 CI failures that blocked publishing DeepSQL Desktop installers. After this lands, re-tag / re-run desktop-release so /download has assets.

Root causes (from failed run)

Platform Failure
Linux Tunnel selftest: Electron aborts — chrome-sandbox lacks root:4755 on hosted runners
macOS electron-builder treated empty CSC_LINK (unset secret → empty string) as a file path → …/desktop not a file
Windows Cancelled after sibling failures; never reached builder

Changes

  • Selftest: ELECTRON_DISABLE_SANDBOX=1 (sandbox irrelevant for headless CI)
  • Build: only export CSC_* when DESKTOP_CSC_LINK is non-empty; otherwise CSC_IDENTITY_AUTO_DISCOVERY=false for unsigned installers
  • desktop/README.md: document the CI behavior

After merge

# Option A — new patch tag from main
git checkout main && git pull
git tag -a desktop-v1.0.1 -m "DeepSQL Desktop v1.0.1"
git push origin desktop-v1.0.1

# Option B — re-run workflow_dispatch on main, then attach assets manually

Then confirm the desktop-v* GitHub Release has dmg/zip/exe/AppImage/deb and /download lists them.

Test plan

  • CI green on this PR
  • After merge: desktop-release succeeds on macOS + Linux + Windows
  • Release assets appear; /download no longer shows empty state
Open in Web Open in Cursor 

cursoragent and others added 2 commits August 28, 2026 16:35
desktop-v1.0.0 failed on all platforms before attach-to-release:
Linux selftest aborted on chrome-sandbox SUID; macOS electron-builder
treated empty CSC_LINK as a file path. Only export signing env when
DESKTOP_CSC_LINK is set; otherwise disable identity discovery. Disable
the Chromium sandbox for CI tunnel selftests.

Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
@venkateshsakamuri-lab
venkateshsakamuri-lab marked this pull request as ready for review August 28, 2026 16:41
@venkateshsakamuri-lab
venkateshsakamuri-lab requested a review from a team as a code owner August 28, 2026 16:41
@venkateshsakamuri-lab
venkateshsakamuri-lab merged commit b04683a into main Aug 28, 2026
9 checks passed
@venkateshsakamuri-lab
venkateshsakamuri-lab deleted the cursor/fix-desktop-release-ci-231a branch August 28, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants