ci(desktop): fix unsigned macOS builds and Linux Electron sandbox - #89
Merged
Merged
Conversation
desktop-v1.0.0 failed on all platforms before attach-to-release: Linux selftest aborted on chrome-sandbox SUID; macOS electron-builder treated empty CSC_LINK as a file path. Only export signing env when DESKTOP_CSC_LINK is set; otherwise disable identity discovery. Disable the Chromium sandbox for CI tunnel selftests. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
desktop-v1.0.0CI failures that blocked publishing DeepSQL Desktop installers. After this lands, re-tag / re-rundesktop-releaseso/downloadhas assets.Root causes (from failed run)
chrome-sandboxlacks root:4755 on hosted runnerselectron-buildertreated emptyCSC_LINK(unset secret → empty string) as a file path →…/desktop not a fileChanges
ELECTRON_DISABLE_SANDBOX=1(sandbox irrelevant for headless CI)CSC_*whenDESKTOP_CSC_LINKis non-empty; otherwiseCSC_IDENTITY_AUTO_DISCOVERY=falsefor unsigned installersdesktop/README.md: document the CI behaviorAfter merge
Then confirm the
desktop-v*GitHub Release has dmg/zip/exe/AppImage/deb and/downloadlists them.Test plan
/downloadno longer shows empty state