Conversation
ian28223
added a commit
that referenced
this pull request
Sep 21, 2026
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
evalya-impact-summaryevalya impact analysis |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: b543de9 | Docs | View more details | Give us feedback! |
Contributor
Disk usage changeCommit Uncompressed
Details
Compressed
Details
|
Contributor
🔄 Dispatcher tests · in progress
Note Tests are still running. 1 of 4 batches has not finished yet. 1 of 855 jobs have not reported.
Batches
❌ Failures⏳ Dispatcher running — GitHub Run. |
When histogram_buckets_as_distributions is enabled, the smallest bucket was misclassified as a negative-domain bucket whenever its upper bound was exactly 0, giving it lower_bound=-Inf. The agent's sketch aggregation silently discards any bucket with an infinite bound, so that bucket's count never reached the resulting distribution metric even though it was still included in .count/.sum. Also relax the equal-bounds guard in the histogram transformer so it only skips the degenerate -Inf/-Inf case, not legitimate single-point buckets like [0, 0]. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ian28223
force-pushed
the
ian.bucad/fix-openmetrics-histogram-zero-bucket-dropped
branch
from
September 21, 2026 05:33
7c91301 to
b543de9
Compare
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes OpenMetrics histogram buckets with
le="0.0"being silently dropped whenhistogram_buckets_as_distributionsis enabled.decumulate_histogram_bucketsclassified the smallest bucket as "negative domain" whenever its upper bound was not> 0. Forle="0.0"(upper bound== 0), this gave itlower_bound = -Infinstead of0..count/.sum(submitted separately) still included it.-Inf/-Infcase, not for legitimate finite single-point buckets like[0, 0]that this fix now produces.Motivation
Customer escalation AGENT-17215: a Solr-backed OpenMetrics histogram with occasional 0ms-latency requests was undercounting its distribution metric by exactly the
le="0.0"bucket's count, because that bucket was silently dropped end-to-end.test_histogram_buckets_as_distributions_with_zero_bucket, reproducing the reported histogram (le="0.0",le="5.0",le="+Inf") and asserting the zero bucket is submitted withlower_bound=0instead of being dropped.ddev test datadog_checks_base -- tests/base/checks/openmetrics/test_v2/— 211 passed, 3 skipped, no regressions.lower_bound:-inf(dropped) before the fix andlower_bound:0(submitted) after.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged🤖 Generated with Claude Code