Conversation
This:
session = LibSSH::Session.new
session.host = "…"
Becomes:
session = LibSSH::Session.new(host: "…")
Right now only host, port and user are migrated. I will add the other
options next. The proxy jump option will receive a LibSSH::Options,
turning libssh_ruby_options into a linked list.
The key function is libssh_ruby_apply_options, designed to be callable
from a libssh proxy jump callback which cannot use the Ruby API.
Though the code is uninterestingly verbose, I am not fond of macros and variadic functions would lose printf’s type checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #16.
Though the code is uninterestingly verbose, I am not fond of macros and
variadic functions would lose printf’s type checking.