Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expired FileStore sessions are still accepted
FileStoreonly enforces expiry throughhandle_expired(), which evicts at most 3 sessions per load, andcontains()never looks at the expiration time. Once more than 3 sessions have expired, a cookie for any expired session that isn't among the 3 oldest still passescontains()inSessionMiddleware::before_handleand gets loaded, so a leaked session id outlives its expiration.contains()now evicts and rejects a key whose tracked expiry has passed.Repro:
FileStore{dir, 0}, log in 8 sessions, wait 1s, request each with its cookie. On master one of them still returned the logged-in user; with the fix, none do.crow_filestore_rejects_expired_sessionfails on master and passes with the patch, and ctest is green.