Repository navigation
do not send a message body in responses to HEAD requests - #1270
Merged
Merged
Conversation
gittiver
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses to HEAD requests include a message body on the wire: do_write_static streams the static file content after the header block even though skip_body already reduced Content-Length to 0, and write_header_into_buffer appends the default error body to HEAD responses with a 4xx/5xx code and an empty body. Any client or proxy treats a HEAD response as ending at the header block (RFC 9112 6.3), so on a reused keep-alive connection the stray bytes are read as the start of the next response and desynchronize it. Skip the file stream and the default error body when skip_body is set, keep the stat-derived Content-Length for static HEAD responses as the equivalent GET would send it, and add a regression test covering both cases.