Added support for TypeScript - #1800
Merged
Merged
Conversation
Coverage Report for CI Build 35122159342Coverage decreased (-0.007%) to 59.82%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Adopted TypeScript v7 into the existing webpack/Babel/Jest toolchain. To minimize changes, the
checkJstypescript config is set tofalse, so existing.js/.jsxfiles are unchecked. As a proof of concept, theButtoncomponent is modified to.tsx, allowing it to be checked with typescript.Because TypeScript 7.0 ships only a native CLI binary with no stable programmatic API yet (expected in 7.1),
ts-loader/fork-ts-checker-webpack-plugin/typescript-eslint's parser aren't usable right now. Babel handles syntax for webpack/Jest, and standalonetschandles type-checking.Adds new command
pnpm run typecheckto run TypeScript type-checking (tsc); this command is integrated into the CI.Also extended ESLint configuration to check
.tsand.tsxfiles. Note: the changes revealed that.jsxfiles currently aren't being linted by ESLint. This should be addressed when migrating files over to typescript.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)