Repository navigation
feat(admin): nextcloud-vue 2.90.0, the admin shell mounts only the open tab - #878
Merged
rubenvdlinde merged 1 commit intoOct 16, 2026
Merged
Conversation
…en tab Bump @conduction/nextcloud-vue to ^2.90.0 and adopt CnAdminSettingsShell's lazyTabs on the admin page, replacing the per-panel v-if on activeTab. Deep links (?tab=<id>), the remembered tab, the tab-change breadcrumb and the sharing tab behave as before. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1953/1953 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-16 17:52 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@conduction/nextcloud-vueto^2.90.0(2.90.0 installed).On the admin page,
CnAdminSettingsShellnow getslazyTabs, and thev-if="activeTab === '<id>'"on eachtab-<id>panel is gone. The shell now mounts only the open tab. The Algemeen cards in the default slot keep their own gate.What I checked
check:schema-l10n,check:manifest,check:l10n-parity,lint:initial-stateandlint:translation-domain: exit 0. eslint on the changed files: exit 0.lazyTabsand that no panel has its ownv-if(13/13 pass). Full suite: 981/981 tests pass. The only red file istests/vitest/shared-instance.spec.ts, which fails to load because of its tsconfig. That failure was already ondevelopment./settings/admin/launchpad:?tab=<id>is written and the tab is remembered.?tab=sharingopens Delen, also after a reload./,/store,/flows,/reports,/reports/dashboardsand/features-roadmap: all render with no console errors and no 4xx responses. The 4 report stat tiles still link.Declared widget props (2.90.0)
The only manifest dashboard is DashboardsReport:
charthas its own branch in the dashboard page, so it is not affected.object-tableis rendered by a host withinheritAttrs: false, so it still gets every key.statreadslabel,icon,format,routeandsourcefromcontent. Before, these keys also landed as stray DOM attributes on the tile's link. Dropping them changes nothing users see.This PR was prepared with Claude Code.