Skip to content

feat(admin): nextcloud-vue 2.90.0, the admin shell mounts only the open tab - #878

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/nextcloud-vue-2.90-lazy-admin-tabs
Oct 16, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
chore/nextcloud-vue-2.90-lazy-admin-tabs

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Bumps @conduction/nextcloud-vue to ^2.90.0 (2.90.0 installed).

On the admin page, CnAdminSettingsShell now gets lazyTabs, and the v-if="activeTab === '<id>'" on each tab-<id> panel is gone. The shell now mounts only the open tab. The Algemeen cards in the default slot keep their own gate.

What I checked

  • Build: exit 0. check:schema-l10n, check:manifest, check:l10n-parity, lint:initial-state and lint:translation-domain: exit 0. eslint on the changed files: exit 0.
  • vitest: the admin tabs spec now asserts lazyTabs and that no panel has its own v-if (13/13 pass). Full suite: 981/981 tests pass. The only red file is tests/vitest/shared-instance.spec.ts, which fails to load because of its tsconfig. That failure was already on development.
  • Live smoke as pieter on /settings/admin/launchpad:
    • Each of the 12 tabs shows its content and is the only panel with content. The breadcrumb follows the tab, ?tab=<id> is written and the tab is remembered.
    • A reload reopens the remembered tab.
    • ?tab=sharing opens Delen, also after a reload.
    • No console errors and no 4xx responses.
  • Live smoke of /, /store, /flows, /reports, /reports/dashboards and /features-roadmap: all render with no console errors and no 4xx responses. The 4 report stat tiles still link.

Declared widget props (2.90.0)

The only manifest dashboard is DashboardsReport:

  • chart has its own branch in the dashboard page, so it is not affected.
  • object-table is rendered by a host with inheritAttrs: false, so it still gets every key.
  • stat reads label, icon, format, route and source from content. Before, these keys also landed as stray DOM attributes on the tile's link. Dropping them changes nothing users see.

This PR was prepared with Claude Code.

…en tab

Bump @conduction/nextcloud-vue to ^2.90.0 and adopt CnAdminSettingsShell's
lazyTabs on the admin page, replacing the per-panel v-if on activeTab. Deep
links (?tab=<id>), the remembered tab, the tab-change breadcrumb and the
sharing tab behave as before.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit c5a4490 into development Oct 16, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 3f0dd62

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅ 1953/1953
Newman ✅ 224/224
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-16 17:52 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant