Repository navigation
fix(reports): dashboard report tiles link to registered routes - #876
Merged
Merged
Conversation
The DashboardsReport stat tiles and the recent list's view-all link resolved the route names "dashboards" and "admin-templates", which no page registers, so vue-router threw MATCHER_NOT_FOUND on every render. They now use Workspace and admin-templates-index, the names the menu already uses. A spec checks every named route in the manifest against the routes routesFromManifest builds. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 1953/1953 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-16 14:27 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stat tiles on /reports/dashboards and the recent list's view-all link resolved the route names
dashboardsandadmin-templates. No page registers those names, so vue-router threw MATCHER_NOT_FOUND (9 console errors per render). They now useWorkspaceandadmin-templates-index, the names the menu already uses for the same targets.A new spec,
src/utils/__tests__/manifestRouteNames.spec.js, checks every{ name }under a key ending in "route", and every menu route, against the routesroutesFromManifestbuilds. It fails when one old name is put back (checked).Verified locally:
tests/vitest/shared-instance.spec.tsfails to load: the tsconfigextendsfrom the server root does not resolve. That fails the same way on development.🤖 Generated with Claude Code