Repository navigation
fix(property-source): the BRP and KvK bindings ask the way their registries answer - #2665
Merged
rubenvdlinde merged 1 commit intoOct 12, 2026
Merged
Conversation
…stries answer
The bindings asked /brp/{bsn} and /kvk/{nummer}, paths neither registry has,
and read a flat record neither returns, so they could not read the mock
answer their own seeded sources ship. BRP now posts
RaadpleegMetBurgerservicenummer to /personen, KvK asks /zoeken. The contract
test reads the answers out of the shipped source fragments.
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
October 12, 2026 13:18
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 143/143 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 5447/5447 · 1 skipped | ||||
| Newman | ✅ 130/130 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-10-12 13:32 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
brpandkvkproperty sources could not read a record from their own seeded sources./brp/{bsn},/brp/suggest,/kvk/{kvkNummer}and/kvk/suggest. Haal Centraal BRP Personen v2 takes a POST to/personen. KvK Zoeken v2 takes a GET on/zoeken. Neither registry has the paths the bindings used.personenandresultaten.The unit tests passed because they handed the gateway double a made-up flat record.
Now:
BrpPropertySource::resolveposts a RaadpleegMetBurgerservicenummer question to/personenand returns the person. The number travels in the body, never in the URL.fieldsin the declared configuration overrides the default field list, because a municipality's authorisation decides which fields it may ask.BrpPropertySource::suggestanswers only for a whole burgerservicenummer and asks the registry nothing otherwise. Haal Centraal has no free search.KvkPropertySource::resolveandsuggestuse/zoeken, bykvkNummerand bynaam.resolvereturns the head office row of that number.RegistrySourceGateway::readtakes an optional JSON body and then posts.Why now
Dossiq held the working wire knowledge in its own BRP and KvK clients. Those clients leave dossiq (ADR-118, hydra design section 5). This is the integriq half of that pair. The dossiq halves: ConductionNL/dossiq#3819 retires the KvK client, and a later dossiq PR moves the one BRP caller onto this binding.
Verified
RegistryProviderContractTestreads the mock answers out oflib/Settings/register.d/brp-haalcentraal-source.jsonandkvk-source.json. Against development 5 of its 7 tests failed, 3 of them with "returned no record" on the shipped answer (refactor/r2/logs/b1-red.log, exit 2).tests/Unit/PropertySource, 35 tests, 99 assertions, exit 0. Includes a newRegistrySourceGatewayTestfor the GET and POST paths.composer check:strictdid not get a build slot before hand-back, so it has not run on this head. CI is the full check.Rollout
No schema, route or version change. Nothing to configure.
Open
Whether the call engine's mock mode answers a POST the same as a GET is not checked here. The live pass covers it.