Repository navigation
feat(stuf): StUF-ZDS writes reach the owning app as generic case operations (decision 206) - #2662
Merged
Merged
Conversation
…ations (decision 206) zakLk01 (create, update) and edcLk01 (document add) are mapped onto generic operations on the mutation events. A kennisgeving is answered with a Bv03 or a Fo03. Each refusal kind has its own refusing HTTP status. A write forwarded from a sibling app's URL is refused.
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
October 12, 2026 07:57
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 143/143 | |||
| npm | ✅ | ✅ 647/647 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 5438/5438 · 1 skipped | ||||
| Newman | ✅ 130/130 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-10-12 08:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Decision 206 (Ruben, 12 Oct): another system may write cases and documents into dossiq over StUF, but only through integriq and authenticated. This is the integriq half. The dossiq half is ConductionNL/dossiq#3801, which lands after this one.
The provider receiver from #2659 already authenticated a zakLk01 and an edcLk01 against the source's WS-Security UsernameToken (with
acceptsProviderRequestsset) and dispatched an event. That event carried raw StUF element names, and dossiq refused every one. Now:StufProviderOperationMappermaps the three StUF-ZDS 1.2 write messages onto generic case operations: creeerZaak (zakLk01, mutatiesoort T) becomescreate, updateZaak (zakLk01, W) becomesupdate, voegZaakdocumentToe (edcLk01, T) becomesadd-document. Keys are generic (title,startDate,caseTypeCode,initiator,content), dates are ISO, and the document bytes are decoded. The mapping is the adapter for a national standard, so it is code here (decision 182). Which case type a zaaktype opens on is configuration in the owning app.buildBv01had no other caller and is removed.refuse()takes a kind, and each kind has its own HTTP status: refused 400, forbidden 403, not found 404, conflict 409. Not authenticated stays 401 and nobody answering stays 500. A fault never travels as HTTP 200.StufProviderRequestReceivedEvent) is refused with 403. So dossiq's old/api/stuf/zakenaddress cannot become a write route. Queries can still be forwarded.What it does not do
Rollout, for an administrator
configuration.acceptsProviderRequests./apps/integriq/api/stuf-zkn/provider/{sourceId}/casesnow gets a Bv03 or Fo03 where it got a Bv01 or Fo01.Verified
StufProviderReceiverTestandStufProviderRequestReceivedListenerTest: 20 tests, 268 assertions, green. A control run with the 403 mapping and the forwarded-write guard broken on purpose turned two tests red (refactor/r2/logs/w1-control-red.log).OC\AppFramework\Middleware\OCSMiddleware. In the bare unit run that class is not loadable, so the test applies its measured rule instead (a 401 or 403 from an OCSController becomes 200). The controller is a plainController, and the test asserts that too.composer check:strict, once, on 1771c35 (refactor/r2/logs/w1-strict.log): no-legacy-types, routes, lint, phpcs, phpmd, psalm and phpstan green. The suite's only red is 11 errors intests/Unit/AppInfo, the same 11 development carries (a DIContainer type in the test double), none in a file this PR touches.