refactor(dossiq): DSO intake default becomes the dso-intake package by rubenvdlinde · Pull Request #3767 · ConductionNL/dossiq

rubenvdlinde · 2026-10-11T21:31:00Z

Status, 12 October

Still a draft for one reason: the packages job was running on the last head (51b9c63, the debt baseline only) when CI was read. It was green on the head before it. #3654 is on development, so this merges on its own.

Holds development with merge train 3 (train: land 18 ready PRs (12 Oct, c) #3809).
composer check:strict passed once on 77cd185: all checks, PHPUnit 8,355 tests. After it: the tightened debt baseline only.
Gate 119: DefaultDsoIntakeSchema is gone, .procedure-code-baseline.json goes from 206 to 205.
.debt-baseline.json: psalm.inlineSuppressions 266 to 265.
CI, read once: "Install packages on a clean instance" was green on 77cd185 and in progress on 51b9c63. Red in CI and not from this pull request: check:debt-ratchet on eslint.inlineDisables (15 against a baseline of 14, the same on development) and the Quality Report that sums the jobs.
The journey runs in the live pass and nightly, not on this pull request (decision 214).

Where a line below disagrees with this section, this section is the current one.

What

The DSO intake default becomes the settings-only case definition package dso-intake, marked install: auto (hydra ADR-118, decisions 185 and 198). This is refactor lane R1. It is cut from #3654's head (e10eb2b), which merge train 2 (#3742) is landing: merge after that.

Package. lib/Settings/packages/dso-intake/ holds one setting. dso_vergunningaanvraag_schema names integriq's dso_verzoek schema by app, register (integriq, then the old openconnector) and slug. The installer resolves it to the schema id at install (Case definition package installer: install procedures from lib/Settings/packages (C19) #3654, REQ-CT-53).
Same behaviour as the repair step. An administrator's value, an empty one included, is kept: the installer only writes a key this instance never set. Without integriq or its schema the install is refused, nothing is written and no version is recorded, so the next upgrade tries again. A settings-only package records its version in the ledger (REQ-CT-54), so a second run reports current.
Deleted: Repair/DefaultDsoIntakeSchema, its two info.xml steps (<post-migration> and <install>) and DefaultDsoIntakeSchemaTest. DsoIntakeCheck now owns the key as its own KEY constant.
Tests: a Newman collection tests/integration/packages/dso-intake.postman_collection.json (the version record, then the setup check reporting a schema id, then that schema's slug through OpenRegister) and a Playwright journey tests/e2e/packages/dso-intake.spec.ts.
Spec: OpenSpec change dso-intake-package (vth-dso-integration requirement modified).

Verified locally

tests/Unit/SetupCheck (4), tests/Unit/Service/CaseDefinition (26), tests/Unit/Settings (303), tests/Unit/Architecture (99), tests/Unit/Repair (394), tests/Unit/AppInfo (83): all exit 0.
The package validates with the real PackageValidator.
phpcs and phpmd on DsoIntakeCheck: exit 0.
COMPOSER_PROCESS_TIMEOUT=0 composer check:strict once, through the slot, on a2d8f47 (r1-logs/r5-dso-strict.log): ALL CHECKS PASSED, PHPUnit 7,322 tests, exit 0.
Not run locally: the Newman collection and the Playwright journey. CI runs both on a clean instance with integriq. The PR stays draft until the journey is green (decision 185).

Known effect

An instance without integriq now logs a dso-intake refusal at warning level on every upgrade. The repair step logged the same case at info.

Inherited

Reds that are also red on development are not touched here.

The settings-only package dso-intake (install auto) points dso_vergunningaanvraag_schema at integriq's dso_verzoek schema, named by register and slug and resolved at install. An administrator's value, an empty one included, is kept. Without integriq or its schema the install is refused and retried on the next upgrade. Deletes Repair/DefaultDsoIntakeSchema, its two info.xml steps and its unit test. DsoIntakeCheck gets its own KEY constant. Adds a Newman collection, the Playwright journey tests/e2e/packages/dso-intake.spec.ts and openspec change dso-intake-package.

…ckage-dso # Conflicts: # appinfo/info.xml

github-actions · 2026-10-12T08:00:16Z

Quality Report — ConductionNL/dossiq @ `5128e8e`

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		❌
check-schema-l10n		✅
check-l10n-js		✅
check-debt-ratchet		❌
check-types-e2e		✅
composer			✅	✅ 109/109
npm			✅	✅ 659/659
app:check-code	⏭️
info.xml	✅
REUSE	❌
lockfile sync		✅
PHPUnit					🚨 NO VERDICT — enabled but never ran
Newman					⏭️
Playwright					⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets `development`, so the suite is asked once per promotion into `beta` and `main` rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into `development`.
Hydra gates					⏭️

Quality workflow — 2026-10-12 08:00 UTC

Download the full PDF report from the workflow artifacts.

github-actions · 2026-10-12T08:25:59Z

Quality Report — ConductionNL/dossiq @ `42578f7`

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		❌
check-schema-l10n		✅
check-l10n-js		✅
check-debt-ratchet		❌
check-types-e2e		✅
composer			✅	✅ 109/109
npm			✅	✅ 659/659
app:check-code	⏭️
info.xml	✅
REUSE	❌
lockfile sync		✅
PHPUnit					🚨 NO VERDICT — enabled but never ran
Newman					⏭️
Playwright					⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets `development`, so the suite is asked once per promotion into `beta` and `main` rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into `development`.
Hydra gates					⏭️

Quality workflow — 2026-10-12 08:25 UTC

Download the full PDF report from the workflow artifacts.

…ckage-dso

github-actions · 2026-10-12T10:41:00Z

Quality Report — ConductionNL/dossiq @ `bbc5c49`

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
check-debt-ratchet		❌
check-types-e2e		✅
composer			✅	✅ 109/109
npm			✅	✅ 659/659
app:check-code	⏭️
info.xml	✅
REUSE	❌
lockfile sync		✅
PHPUnit					🚨 NO VERDICT — enabled but never ran
Newman					⏭️
Playwright					⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets `development`, so the suite is asked once per promotion into `beta` and `main` rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into `development`.
Hydra gates					⏭️

Quality workflow — 2026-10-12 10:40 UTC

Download the full PDF report from the workflow artifacts.

github-actions · 2026-10-12T14:12:22Z

Quality Report — ConductionNL/dossiq @ `437062b`

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
check-debt-ratchet		❌
check-types-e2e		✅
composer			✅	✅ 109/109
npm			✅	✅ 659/659
app:check-code	⏭️
info.xml	✅
REUSE	❌
lockfile sync		✅
PHPUnit					🚨 NO VERDICT — enabled but never ran
Newman					⏭️
Playwright					⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets `development`, so the suite is asked once per promotion into `beta` and `main` rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into `development`.
Hydra gates					⏭️

Quality workflow — 2026-10-12 14:12 UTC

Download the full PDF report from the workflow artifacts.

rubenvdlinde and others added 2 commits October 11, 2026 23:02

Merge remote-tracking branch 'origin/development' into refactor/r1-pa…

40b1275

…ckage-dso # Conflicts: # appinfo/info.xml

style(packages): the dso-intake journey is formatted

c57c72b

rubenvdlinde mentioned this pull request Oct 12, 2026

train: land 18 ready PRs (12 Oct, c) #3809

Merged

rubenvdlinde added 3 commits October 12, 2026 11:22

Merge remote-tracking branch 'origin/development' into refactor/r1-pa…

797eaa1

…ckage-dso

chore(gates): procedure-code baseline lowered to 205 (gate 119)

917b781

Merge remote-tracking branch 'origin/development' into refactor/r1-pa…

77cd185

…ckage-dso

chore: tighten the debt ratchet

51b9c63

This was referenced Oct 12, 2026

train: land 19 ready PRs (12 Oct, d) #3845

Merged

train: land 6 ready PRs (12 Oct, e) #3855

Merged

rubenvdlinde merged commit 5727032 into development Oct 12, 2026
49 of 51 checks passed

Navigation Menu

Repository navigation

refactor(dossiq): DSO intake default becomes the dso-intake package - #3767

refactor(dossiq): DSO intake default becomes the dso-intake package#3767
rubenvdlinde merged 7 commits into
developmentfrom
refactor/r1-package-dso

rubenvdlinde commented Oct 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

rubenvdlinde commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status, 12 October

What

Verified locally

Known effect

Inherited

Uh oh!

github-actions Bot commented Oct 12, 2026

Quality Report — ConductionNL/dossiq @ 5128e8e

Uh oh!

github-actions Bot commented Oct 12, 2026

Quality Report — ConductionNL/dossiq @ 42578f7

Uh oh!

github-actions Bot commented Oct 12, 2026

Quality Report — ConductionNL/dossiq @ bbc5c49

Uh oh!

github-actions Bot commented Oct 12, 2026

Quality Report — ConductionNL/dossiq @ 437062b

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rubenvdlinde commented Oct 11, 2026 •

edited

Loading

Quality Report — ConductionNL/dossiq @ `5128e8e`

Quality Report — ConductionNL/dossiq @ `42578f7`

Quality Report — ConductionNL/dossiq @ `bbc5c49`

Quality Report — ConductionNL/dossiq @ `437062b`