Repository navigation
feat(ui): meetings list to board DcVergaderingen: lenses and columns - #1712
Merged
Merged
Conversation
…and the board's columns Upcoming (default), This month, Completed and All as quick filters with counts; columns Date and time, Body (title under it), Location, Agenda items, Status, Chair; title, meeting type and mode stay as hidden columns; soonest first; search placeholder 'Search in this list'.
…e date lenses, board footer note
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 13, 2026 13:26
Contributor
Quality Report — ConductionNL/decidiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-nav-ceiling | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 652/652 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 2656/2656 · 8 skipped | ||||
| Newman | ✅ 363/363 · 1 skipped | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-13 13:32 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meetings list gets the board's lenses and columns (board DcVergaderingen). Manifest configuration and Dutch strings only, no app component.
What changed
scheduledDate[gte] @now), Deze maand (@monthStartto@nextMonthStart), Afgerond (lifecycle: closed, counted), Alles (counted)labelField, the meeting title as second line), Locatie, Agendapunten (count of agenda items, "nog geen" for zero), Status (badge with colorMap), Voorzitter (participant name via fkResolve)What a user had before, and where it is now
hidden: truebecause 2.81 renders such a column anyway (gap 9 below).Library gaps, named and not built here
endDate):widget: datehas one line. Needs a block variant with anendField.secondaryfills the stored value, so an enum reads "regular". Needs enum labels insecondary.chairholds a Participant uuid;fkResolvegives the name but no avatar.quickFilters[]has nosort.fetchFilterCounts.singleEqualityOftreats a flatscheduledDate[gte]key as an equality and counts it through the aggregate endpoint, which answers 0 while the list shows 5. Needs: a key ending in[op]counted viafetchListTotal.hidden: trueis ignored without a saved column set.Also not this PR: the status label "Bijeengeroepen" (the meeting schema has no
x-enum-labels; "scheduled" reads "gepland"), the page title and count line (held draft #1708), the Acties menu (nextcloud-vue #1551).Pixel diff against DcVergaderingen (user pieter)
Content: data differs (12 test meetings, no body, chair or location on most).
Verified locally
npm run lintnpm run check:manifestnpm run test:l10nnpm run check:l10n-jsnpm run buildnpx vitest run --maxWorkers=2(full)tests/vitest/shared-instance.spec.tsdoes not load (@vue/tsconfignot installed). Inherited, untouched.No PHP changed.
🤖 Generated with Claude Code