feat(sharing): unified document + list sharing screen (web parity) - #31
Merged
Adron merged 1 commit intoAug 31, 2026
Merged
Conversation
Replaces the scattered Share / Invite by email / Collaborators / Watchers sheets with one SharingView mirroring the web "Access & Permissions" page, for both documents (collaborators) and lists (watchers). - Access & Permissions: search + "Role for new users" + an "Email this person" toggle (the notify flag, default on) + members list with role menu, per-user "Get link", and Remove. - Invite by email (pending + revoke) and Share links (Viewer/Editor/Admin labels, Never/7d/30d expiry presets) + a Make-public toggle with a copyable public link. - Foundations: WatcherRole.accessLabel/linkLabel, ShareExpiryPreset, ILWebURL.publicResource/resource, and notify on addWatcher/setWatcherRole (documents already had it). - DocumentsView and ListsView now open the single SharingView. - Tests: role labels, expiry presets, watcher notify body, ILWebURL builders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V16mvNBWyYLncSQL8isDNF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings iOS document (and list) sharing to parity with the web's single "Access & Permissions" screen. The capabilities existed but were scattered across separate sheets (Share / Invite by email / Collaborators / Watchers) with the public toggle buried in Edit — which is why it "didn't appear to show up." This replaces them with one
SharingView, generic over documents (collaborators) and lists (watchers).What's included
notifyflag; default on) + a members list with role menu, per-user Get link, and Remove.WatcherRole.accessLabel/linkLabel,ShareExpiryPreset,ILWebURL.publicResource/resource, andnotifyadded to the listaddWatcher/setWatcherRole(documents already had it).DocumentsView/ListsViewnow open the singleSharingView.Testing
notifybody, ILWebURL builders).Caveats
qa-screenshotterpass.DocumentCollaboratorsView,WatchersListView,ShareLinksSheet,ShareInvitesSheet) are now orphaned; removal left as a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01V16mvNBWyYLncSQL8isDNF