Repository navigation
Phase 7: comparison against the published results - #9
Merged
Merged
Conversation
Regenerates every side-by-side table from the committed MATLAB outputs, so the comparison is reproducible rather than quoted. Uptakes are compared unsigned: GECKO 2 splits reversible reactions, so its glucose uptake is a positive flux on r_1714_REV where this pipeline has a negative flux on r_1714.
edkerk
force-pushed
the
feat/py-phase6-sampling
branch
from
September 25, 2026 11:33
3cd51e1 to
4c90c01
Compare
edkerk
force-pushed
the
feat/py-phase7-comparison
branch
from
September 25, 2026 11:33
aa60824 to
bb6ad0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the series, stacked on #8. Regenerates every side-by-side table this
port has been quoting, from the committed MATLAB outputs, so the comparison is
reproducible rather than asserted in a PR description.
Writes
results/COMPARISON.mdwith three sections:residual over glucose, CO2 and oxygen.
selectedFluxes.Each section appears only if the corresponding results are present, so it works
on a partial run.
One thing worth a test
GECKO 2 splits reversible reactions, so its glucose uptake is a positive flux on
r_1714_REVwhile this pipeline has a negative flux onr_1714. Comparing themunsigned is the point of the module, and a test feeds it the legacy fluxes
reshaped as new ones and requires both columns to agree — which catches reading
either format wrongly.
Also
README covers the build options, the sampled budget, the order the steps run in,
and the test markers. 188 tests in this branch.