Repository navigation
Use Gurobi as the default solver - #10
Merged
Merged
Conversation
The analysis and the tests now use Gurobi unless --solver or OVERFLOW_SOLVER names another; an unavailable solver is an error instead of a silent switch. CI has no licence and sets OVERFLOW_SOLVER=glpk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gurobi is now the default solver for the analysis and the tests. Before, the
README said the tests ran on GLPK, and the scripts used whichever solver cobrapy
picked.
overflowselects the solver on import: Gurobi, or$OVERFLOW_SOLVER, or what--solvernames on any of the four commands.tests/conftest.pyno longer defaults to GLPK;tests/test_solver.pycovers thedefault, the override and the error.
ci.ymlsetsOVERFLOW_SOLVER: glpkfor the test step, which is the only workflow change.
The full suite (192 tests, including the integration builds) passes on Gurobi.