Repository navigation
fix(demo): operator identity from env + enable embedding selector - #72
Merged
Merged
Conversation
Two presentation-readiness fixes: 1. Hard-coded "oncall-alice" replaced everywhere in the frontend. A new OPERATOR_NAME constant reads VITE_OPERATOR_NAME (defaults to "demo-operator") and is used in decideApproval(), the Governance proposal decide() call, the RBAC policy display row, and the draftAsync() call in Incidents. Every approval, rejection, and runbook-draft request now shows a real, configurable actor in the audit trail. 2. INTELLIOPS_RUNBOOK_SELECTOR_MODE wired into docker-compose (rca service) defaulting to "embedding". The embedding runbook selector was implemented and tested (ADR-026) but never activated in compose, so it silently never ran. Now it runs by default; override to "off" to restore keyword-only behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 22, 2026
Mehulsri07
pushed a commit
to Mehulsri07/intelliops
that referenced
this pull request
Sep 23, 2026
PR CodexManvik#72 made the console act as VITE_OPERATOR_NAME, defaulting to "demo-operator", but that name was in no role in rbac_policy.yaml and the console image never set the variable. Every Approve, Reject and "Draft a runbook with AI" click from a stock build was a 403. Grant demo-operator [operator, approver], pin it as a build ARG in Dockerfile.frontend so the identity is explicit and overridable, and add a test that reads the default from api.ts and the Dockerfile and checks it against the policy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operator identity: hard-coded
"oncall-alice"removed from all functional frontend code. A newOPERATOR_NAMEconstant readsVITE_OPERATOR_NAME(defaults to"demo-operator"). Every approval, rejection, runbook-draft request, and the RBAC policy display now use this value — so the audit trail shows a real, configurable actor during the presentation.Embedding selector finally active:
INTELLIOPS_RUNBOOK_SELECTOR_MODEwas never set indocker-compose.yml, so the semantic runbook selector (ADR-026,all-MiniLM-L6-v2, cosine similarity) silently never ran despite being fully implemented and tested. Now defaults toembeddingin compose. Override tooffto restore keyword-only behaviour.Files changed
frontend/src/data/api.tsOPERATOR_NAMEconstant fromVITE_OPERATOR_NAMEenv; used as default indecideApproval()frontend/src/views/Governance.tsxdecide()and RBAC policy table useOPERATOR_NAMEfrontend/src/views/Incidents.tsxdraftWithAI()usesOPERATOR_NAMEdeploy/docker-compose.ymlINTELLIOPS_RUNBOOK_SELECTOR_MODEto rca service, defaulting to"embedding"Test plan
npm run buildclean (112/112 contrast checks pass — verified locally)uv run pytestgreen (no Python changes)VITE_OPERATOR_NAME=your-nameindeploy/.env,docker compose up, approve an incident — audit trail shows your name🤖 Generated with Claude Code