Repository navigation
Add typescript-type-guard logo to README.md - #7
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Coderrob/typescript-type-guards/sessions/5a1ce582-ca64-43b2-9480-b418fcc818d6 Co-authored-by: Coderrob <7213776+Coderrob@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a centered project logo image to the top of the README to improve repository/package presentation.
Changes:
- Inserted an HTML block in
README.mdto render the logo image centered under the main heading.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # typescript-type-guards | ||
|
|
||
| <p align="center"> | ||
| <img src="public/img/typescript-type-guard-logo.png" alt="typescript-type-guards logo" /> |
There was a problem hiding this comment.
The image is referenced via a relative path (public/img/...). Since package.json only publishes dist in the files array, public/ won’t be included in the npm package and the logo will be broken on the npm README page. Consider switching src to an absolute GitHub raw/asset URL, or include public/img in the published package (update files in package.json) so the relative link can resolve.
Suggested change
| <img src="public/img/typescript-type-guard-logo.png" alt="typescript-type-guards logo" /> | |
| <img src="https://raw.githubusercontent.com/OWNER/REPO/main/public/img/typescript-type-guard-logo.png" alt="typescript-type-guards logo" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent-Logs-Url: https://github.com/Coderrob/typescript-type-guards/sessions/5a1ce582-ca64-43b2-9480-b418fcc818d6