Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitData({ data: { a: 1, b: 2 }, maxChunkSize: 12 })currently returns a single 13-character JSON object. Appending a property to a nonempty object removes two braces but adds a comma, so the combined length must subtract one character rather than three. The same undercount affects recursively split properties.Correct both object-length calculations and add regression cases for ordinary properties, recursively split properties, and an object that exactly fits its limit.
Validation: all 19 tests in
common/src/util/__tests__/split-data.test.tspass with Bun 1.3.14, including two regression cases that fail before the fix. The two changed files also pass strict TypeScript checking, ESLint, andgit diff --check.