Fix BuffBench terminal crashes with numeric env values - #1395
Open
yolandaycao wants to merge 1 commit into
Open
yolandaycao wants to merge 1 commit into
yolandaycao wants to merge 1 commit into
Conversation
Contributor
|
Good catch and a minimal, well-scoped fix. The root cause is clearly explained: BuffBench eval JSON configs can produce non-string env values (e.g. A couple of things worth double-checking before porting:
Overall: correct, narrowly scoped, addresses a real crash with a believable repro. Worth porting. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuffBench configs can contain numeric env values like
PORT: 3003. The SDK calls.trim()when scrubbing credentials, so terminal commands crash before starting.Convert env values to strings before passing them to the SDK. Verified that
printenv PORTsucceeds with credential scrubbing enabled.