Skip to content

Manchester | 26-ITP-Sept | Fatima Rouchi | Sprint 1 | Format clock edge cases #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatimarouchi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Sept | Fatima Rouchi | Sprint 1 | Format clock edge cases #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d90021c
add more tests
fatimarouchi Oct 15, 2026
4c0993b
fix error
fatimarouchi Oct 15, 2026
42a5ebc
complete timeConverter.js ex
fatimarouchi Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3);
if (hours === 0) {
return `12:${minutes} am`;
}

if (hours === 12) {
return `${time} pm`;
}
if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${hours - 12}:${minutes} pm`;
}
return `${time} am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
30 changes: 25 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,31 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time after 12:00", function () {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("correctly convert noon", function () {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});

test("correctly convert midnight", function () {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("preserves minutes in afternoon times", function () {
assert.equal(formatAs12HourClock("13:45"), "1:45 pm");
});

test("correctly converts 13:00", function () {
assert.equal(formatAs12HourClock("13:00"), "1:00 pm");
});

test("correctly converts 11:00", function () {
assert.equal(formatAs12HourClock("11:00"), "11:00 am");
});
Loading