Repository navigation
London | 26-ITP-Sep | Alan Mak | Sprint 2 | Implement and rewrite tests - #1695
Open
AlanGit-debug2604 wants to merge 26 commits into
Open
AlanGit-debug2604 wants to merge 26 commits into
AlanGit-debug2604 wants to merge 26 commits into
Conversation
…ction's purpose and expected behavior
…tion's purpose and expected behavior
…d edge cases: not a number, not a finite number, 0 as denominator
… type of card ; define Rank and Suit composing value of card, define validRanks and valid Suits;
…oper fraction, 0 numerator, 0 denominator, non-numeric numerator , non-numeric denominator, not a number (NaN), infinity denominator
…d rank and suit inputs
…rank and suit inputs
…g for invalid inputs
…r edge cases and error handling
AlanGit-debug2604
added
📅 Sprint 2
…ingle occurrences, and edge cases
…th 1, 2, 3, 11, 12, 13, and all other numbers
… in 1, 2, and 3, but excluding 11, 12, and 13 respectively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1059
Changelist
Write implementation, node tests, and Jest tests for 1-get-angle; 2-is-proper-fraction; and 3-get-card-values.
Tested and passed tests.
Questions
Housekeeping question: followed by npm installation in Prep, should package.json stay with coursework folder and commit. The reason of this question: in package.json configuration `"devdependencies" : "jest : "^30.5.2" has set up. Is the placement of this file essential to run jest test for implementation files?