Repository navigation
Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 2 | TDD - #1687
Open
chefmatthaus-hub wants to merge 3 commits into
Open
chefmatthaus-hub wants to merge 3 commits into
chefmatthaus-hub wants to merge 3 commits into
Conversation
chefmatthaus-hub
added
the
Needs Review
hackertainment
added
Review in progress
There was a problem hiding this comment.
Your test cases are correct. Just for you to think a little bit more, besides str = "hello" or str = "bye", what special string should also be added to each of the test cases?
hackertainment
added
Reviewed
Comment on lines
+20
to
+25
| test("should return 0 when character is not found", () => { | ||
| const str = "hello"; | ||
| const char = "z"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }); |
There was a problem hiding this comment.
There should be a special str that gives 0 anyway. Please add that test case as well. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1060