Skip to content

London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | Implement and rewrite test - #1678

Open
leerogerfn wants to merge 15 commits into
CodeYourFuture:mainfrom
leerogerfn:coursework/sprint-2
Open

London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | Implement and rewrite test#1678
leerogerfn wants to merge 15 commits into
CodeYourFuture:mainfrom
leerogerfn:coursework/sprint-2

Conversation

@leerogerfn

@leerogerfn leerogerfn commented Oct 11, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1059

Changelist

Completed writing functions, node test and jest test

Questions

:)

@leerogerfn
modified the import function to come first. written the condition of …
ede90ec 
…reflex angle. test for reflex angle succeed.
@leerogerfn
written condition for straight angle and confirm the test is success.
c7e5979
@leerogerfn
written condition for obtuse angle and test successful.
6973f9e
@leerogerfn
written condition for right angle and confirm the test successful.
855ddcc
@leerogerfn
written condition for acute angle and test successful.
56b9d32
@leerogerfn
written condition for invalid angle. confirm the test successful.
f406580
@leerogerfn
initialise the test.
70fd5b5
@leerogerfn
written functions and test successful for success fraction
5b8ba78
@leerogerfn
initialised test for 3-get-card-value
09cd676
@leerogerfn
written function for get-card-value
d8839f1
@leerogerfn
Complete the Jest test for 1-get-angle-type-test.
a0ed029
@leerogerfn
completed the jest test for 2-proper-fraction-test.js
4c5ad3a
@leerogerfn
initialise package.json
f0d67f2
@leerogerfn
modified the throw error in jest test in 1-get-card-value.
5114047
@leerogerfn
format document
c67d63d
@github-actions

This comment has been minimized.

Sign in to view
@leerogerfn leerogerfn changed the title London | 26-ITP-Sept | Fung Nin Lee | Sprint-2 | Implement-and-rewrite-tests London | 26-ITP-Sept | Fung Nin Lee | Sprint-2 | Implement and rewrite test Oct 11, 2026
@github-actions

This comment has been minimized.

Sign in to view
@leerogerfn leerogerfn added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2026
@github-actions

This comment has been minimized.

Sign in to view
@leerogerfn leerogerfn changed the title London | 26-ITP-Sept | Fung Nin Lee | Sprint-2 | Implement and rewrite test London | 26-ITP-Sept | Fung Nin Lee | Sprint 2 | Implement and rewrite test Oct 11, 2026
@leerogerfn leerogerfn added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leerogerfn