London | 26-ITP-Sep | Ebrahim Moqbel | Sprint 1 | Form Controls - #1462
Open
Ebrahim-Moqbel wants to merge 13 commits into
Open
London | 26-ITP-Sep | Ebrahim Moqbel | Sprint 1 | Form Controls #1462Ebrahim-Moqbel wants to merge 13 commits into
Ebrahim-Moqbel wants to merge 13 commits into
Conversation
… shirt color and changed th name to match the ID attribute.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ebrahim-Moqbel
changed the title
Ebrahim-Moqbel
changed the title
Ebrahim-Moqbel
changed the title
Ebrahim-Moqbel
added
the
Needs Review
Ebrahim-Moqbel
added
📅 Sprint 1
Ebrahim-Moqbel
changed the title
Ebrahim-Moqbel
changed the title
Luro91
added
the
Review in progress
Luro91
reviewed
Sep 10, 2026
Comment on lines
+31
to
+32
| <div> | ||
| <label for="black"> |
There was a problem hiding this comment.
The standard for child elements is to make them more visible in the code by using indentation. How can you ensure your code is formatted according to standards?
|
|
||
| <div> | ||
| <label for="name"> Name*: </label> | ||
| <input type="text" id="name" name="name" required minlength="2"> |
There was a problem hiding this comment.
Min length is a good idea but also allows 2 space characters to be entered and passing the validaiton. How can you ensure the characaters are not spaces?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
I am opening this this pull request to merge any updates to the changes of the requirements provided
Questions
N/A