comments: the two references to the command-vocabulary gate name its … - #6
Merged
Merged
Conversation
…check module, not the deleted script `src/hooks/useEngineLifecycle.ts` and `src/types/engine.ts` each explain that this client does not re-declare the engine command vocabulary because a gate in the superproject asserts set equality against `coderoast-server`'s `command_catalog.hpp`. Both named that gate as `scripts/command_vocabulary_lint.py`, a file that was DELETED in the superproject on 2026-09-17 when the gate became the `pharos check` module `scripts/pharos/checks/command_vocabulary.py` (superproject plan row DN-108.P1.2 — every gate becomes a check module, DN-108.D2, and a module is never run by path). Both comments now name the one spelling an agent or a desk types, `pharos check --module command_vocabulary`. Vocabulary only: no TypeScript changes, no behaviour changes, and the point both comments make is unchanged — the gate is deliberately NOT in this repository's suite, because only a full workspace checkout holds both sides of the seam, and the vitest arm that tried to reach across the repository boundary threw ENOENT on every run for a month while the pipeline reported green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DgF1dGH16hPwX7aaaKguWw
✅ Deploy Preview for elaborate-malasada-e00aa3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔬 Sift — structural diff of your CI logs
✅ No structural change. 509 → 509 log lines, same behaviour. Deterministic — same inputs, same comment. Runs in your CI; your logs never leave it. · What is this? · Baseline: last green run on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…check module, not the deleted script
src/hooks/useEngineLifecycle.tsandsrc/types/engine.tseach explain that this client does not re-declare the engine command vocabulary because a gate in the superproject asserts set equality againstcoderoast-server'scommand_catalog.hpp. Both named that gate asscripts/command_vocabulary_lint.py, a file that was DELETED in the superproject on 2026-09-17 when the gate became thepharos checkmodulescripts/pharos/checks/command_vocabulary.py(superproject plan row DN-108.P1.2 — every gate becomes a check module, DN-108.D2, and a module is never run by path). Both comments now name the one spelling an agent or a desk types,pharos check --module command_vocabulary.Vocabulary only: no TypeScript changes, no behaviour changes, and the point both comments make is unchanged — the gate is deliberately NOT in this repository's suite, because only a full workspace checkout holds both sides of the seam, and the vitest arm that tried to reach across the repository boundary threw ENOENT on every run for a month while the pipeline reported green.
Claude-Session: https://claude.ai/code/session_01DgF1dGH16hPwX7aaaKguWw