Repository navigation
vendor: pin llama.cpp to f002015a4, so a restored KV page keeps its adapters (fork #54) - #4947
Merged
joelteply merged 1 commit intoOct 11, 2026
Conversation
…dapters (fork #54) One commit over af1a3c933: SLOT_SAVE writes a `.lora` sidecar (each loaded adapter's path, scale, file size and mtime), and SLOT_RESTORE sets the slot's adapters from it, refusing a missing or foreign one. A turn with genes after a restore then keeps the restored KV, instead of reading as an adapter change and clearing it (the 5090, card e5eaf9f4). An adapter-free task now runs the same change check. The core already drains `.lora` with its page (#4942). After deploy, each mind's first restore of a page saved before this is refused once (no sidecar): one cold prefill per mind, then the page is dropped. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FRQWzgSfo79JtnwZywHKrE
Contributor
Author
|
Approve (BigMama, as a comment: shared account). Claims verified: the gitlink and core/vendor/LLAMA_CPP_PIN both move af1a3c933 -> f002015a4; f002015a4 is fork #54 squashed onto af1a3c933 (one parent, ahead by 1, one file, tools/server/server-context.cpp); and the new .lora sidecar is already disk-safe on canary: #4942 put it in slots.rs PAGE_SIDECARS ([".ckpt", ".lora"]), so trims remove it with its page. After deploy I own the receipt (a gene turn after a restore logs no 'clearing cache for lora change', cache_n > 0). Ordering note: #4939 and #4946 also bump or need this pin; whichever lands second rebases onto the newer pin, never back to af1a3c933. |
joelteply
deleted the
cc99d214/vendor-pin-llama-cpp-to-f002015a4-fork-5
branch
October 11, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This pins
core/vendor/llama.cppto f002015a4, moving the gitlink andLLAMA_CPP_PINtogether. It is one commit over af1a3c933: fork CambrianTech/llama.cpp#54, which BigMama and Fable approved and which merged..lorasidecar with each loaded adapter's path, scale, file size and mtime. SLOT_RESTORE sets the slot's adapters from it and refuses one that is missing or foreign.The core already drains
.lorawith its page (#4942, merged).Expected after deploy (not a regression)
Pages saved before this have no sidecar, so each mind's first restore is refused once. That is one cold prefill, after which the page is dropped.
Measured
This can only be measured after deploy. The check: on the 5090, a gene turn that follows a restore logs no
clearing cache for lora changefor that slot, and itscache_nis above 0. Owner: Cormac, with BigMama pulling the log lines. Deadline: the first 5090 deploy carrying this pin. The receipt card stays open until it is posted with the build SHA and a timestamp.Coordination
#4939 also moves this pin, for fork #52. Whichever lands second rebases onto fork master, which then carries both.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FRQWzgSfo79JtnwZywHKrE