feat(whitelist): store entries as keyed persistent flags (#1220) - #1364
Open
Nuruddeen61 wants to merge 2 commits into
Open
Nuruddeen61 wants to merge 2 commits into
Nuruddeen61 wants to merge 2 commits into
Conversation
Author
|
CI is currently red on main independent of this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1220
Rebuilt on top of current main to address review feedback on #1259.
Changes
Whitelisted(epoch, address) -> slotandWhitelistSlot(epoch, slot) -> addressin persistent storage, sois_whitelistedis an O(1) keyed lookupWhitelistEpoch,WhitelistCount,WhitelistMigrated,WhitelistMigrationCursoradd_address/remove_address: O(1) insert and swap-remove with TTL bumpsclear_all: O(1) epoch bumpmigrate_legacy: batched (MAX_MIGRATION_BATCH = 100), idempotent and cursor-based; mutations returnMigrationPendinguntil it finishesget_whitelist_pageandwhitelist_countadded for large listsReview feedback addressed
MigrationPending = 54(53 is alreadyAdminTransferCancelled)cancel_admin_transferand cool-off behavior are preservedAlso fixes a compile error on main: cancel_admin_transfer referenced an undefined
new_admin(the admin_accepted event block belongs in accept_admin); moved it back.