fix(harvester): match parent DOI as well as version DOI - #986
Open
TahaKhan998 wants to merge 1 commit into
Open
TahaKhan998 wants to merge 1 commit into
TahaKhan998 wants to merge 1 commit into
Conversation
kpsherva
reviewed
Sep 23, 2026
TahaKhan998
force-pushed
the
fix/matcher-parent-doi
branch
from
September 23, 2026 14:42
99c88af to
7599e7e
Compare
kpsherva
reviewed
Sep 23, 2026
| from .utils import legacy_entry | ||
|
|
||
|
|
||
| def test_doi_match_filter_searches_version_and_parent_doi(): |
Contributor
There was a problem hiding this comment.
what will happen in terms of create/update? will it work properly? which version will be updated if the parent is found?
Author
There was a problem hiding this comment.
well if no match is found then it creates a new record, if the parent doi matches then the search only returns the latest version by default and that is what gets updated. if we want a specific version to be updated then we could find the specific version using the resource type of the incoming inspire record maybe?
TahaKhan998
force-pushed
the
fix/matcher-parent-doi
branch
3 times, most recently
from
September 24, 2026 09:06
35df655 to
0b2365b
Compare
TahaKhan998
force-pushed
the
fix/matcher-parent-doi
branch
from
September 24, 2026 09:29
0b2365b to
b4b3692
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #347
The matcher only searches pids.doi (the version DOI). For some hand-submitted records INSPIRE has the parent DOI instead, so we miss the existing CDS record and create a duplicate. DOIMatchFilter now also searches parent.pids.doi, so either DOI is enough to match.