fix(config): disallow versioning for external DOIs - #973
Open
TahaKhan998 wants to merge 1 commit into
Open
TahaKhan998 wants to merge 1 commit into
TahaKhan998 wants to merge 1 commit into
Conversation
kpsherva
reviewed
Sep 21, 2026
| return (source or "").lower() in _ARXIV_SOURCES | ||
|
|
||
|
|
||
| def keep_shared_doi_on_latest(latest_entry, versions): |
Contributor
There was a problem hiding this comment.
let's discuss this IRL with the team
Contributor
There was a problem hiding this comment.
more context - this is because of the external DOIs not being displayed on the latest version and if harvester adds a new version, the DOI will not be displayed on the latest
suggested approach: not to create versions for external DOIs, both in migration and harvester
ON HOLD
Contributor
There was a problem hiding this comment.
discussed:
when we are updating records with external DOIs, we should keep one version only (check how zenodo implements this - the feature is already there, it is a question of setting the permissions correctly)
TahaKhan998
force-pushed
the
fix/issue-943-doi-on-latest-version
branch
from
September 22, 2026 14:47
4bf8f6f to
5b5ade0
Compare
TahaKhan998
force-pushed
the
fix/issue-943-doi-on-latest-version
branch
from
September 24, 2026 14:05
5b5ade0 to
8b2801f
Compare
TahaKhan998
changed the title
kpsherva
approved these changes
Sep 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #943
same as zenodo, curators shouldn't be able to create a new version of a record that has an external DOI. set RDM_ALLOW_EXTERNAL_DOI_VERSIONING = False.