Repository navigation
Conversation
Coverage Report for CI Build 38962498713Coverage increased (+0.9%) to 92.473%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
jkalayan
deleted the
77-feature-support-submissions-across-multiple-gunicorn-workers
branch
October 16, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the workflow upload directory handling in a multi-worker environment, ensuring that workflows are consistently accessible across all Gunicorn workers.
Workflow directory management and multi-worker support:
_dir_for) inWorkflowStoreso that all Gunicorn workers use the same upload directory for a given workflow, replacing the previous random directory approach. This ensures that workflows are accessible regardless of which worker handles the request.resetandgetmethods inWorkflowStoreto use the deterministic directory, recover workflow state from disk if created by another worker, and synchronize activity timestamps usingos.utimeto signal liveness across workers.make_upload_tmpdir, simplifying directory management and making the process more predictable.Deployment improvements:
gthreadworker class with multiple workers and threads, improving concurrency and ensuring compatibility with the new shared directory approach.Testing:
tests/test_form/test_workflows.py) to verify workflow directory creation, recovery from disk, error handling for invalid IDs, deletion, and cleanup of expired workflows.