feat: add DjVu conversion support - #612
Open
al-n wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class DjVu conversion support by installing DjVuLibre tooling in the production image, registering a new DjVu converter, and adding unit tests + documentation so DjVu inputs can be converted to PDF/TIFF via ddjvu.
Changes:
- Install
djvulibre-bin(forddjvu) in the Docker release image. - Add a new
djvuconverter and register it in the converter dispatch table. - Add unit tests for converter metadata/arguments and document the converter in the README.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Dockerfile |
Installs djvulibre-bin to provide ddjvu in the production image. |
src/converters/djvu.ts |
Introduces ddjvu-based DjVu→PDF/TIFF conversion implementation. |
src/converters/main.ts |
Registers the new converter in the global dispatch table. |
tests/converters/djvu.test.ts |
Adds unit tests for DjVu converter properties and invocation args (plus common converter behaviors). |
README.md |
Documents DjVuLibre as a supported converter and updates counts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ddjvuutility in the production imageddjvuNotes
ddjvurenders each page into the resulting PDF or TIFF. This supports scanned/image-only DjVu documents that Calibre cannot convert, but it does not preserve an embedded searchable text layer.Testing
bun test— 107 passed, 8 skipped, 0 failedtsc --noEmitknipCloses #583
Summary by cubic
Adds DjVu-to-PDF and DjVu-to-TIFF conversion via
ddjvu, so DjVu inputs that previously failed now convert. Output is rasterized; embedded searchable text is not preserved.djvulibre-bin.djvuconverter for.djvu/.djvand restores its priority ahead of generic document converters.ddjvu -format=<pdf|tiff>and logs stdout/stderr.Rollout
djvulibre-binor use the updated image.Written for commit b9f49f0. Summary will update on new commits.