Repository navigation
add check for daglen exaggeration - #350
Open
stringhandler wants to merge 1 commit into
Open
stringhandler wants to merge 1 commit into
stringhandler wants to merge 1 commit into
Conversation
When decoding a simplicity program, the dag length is read first. Currently, we allocate memory according to that length without checking whether the program is actually that long. This could be used to allocate more memory than needed. Here we add a check that the length of the DAG on stream is within the size of that length before allocating.
Author
|
Related to #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decoding a simplicity program, the dag length is read first. Currently, we allocate memory according to that length without checking whether the program is actually that long. This could be used to allocate more memory than needed. Here we add a check that the length of the DAG on stream is within the size of that length before allocating.