Repository navigation
doc: Add unshared secret generation to wallets.md - #71
BenWestgate wants to merge 3 commits into
Conversation
Updated import support specifications for wallet seed lengths and error correction handling. Added details on generation support for codex32 secrets and share sets.
Clarified wallet behavior for invalid headers and checksums, improved error correction guidance, and refined display and confirmation processes for codex32 strings. Removed SSS section for brevity.
Refine guidance on generating unshared secrets and update codex32 secret backup process. Improve clarity on identifier policies and human-readable parts.
|
@roconnor-blockstream This is ready for review. |
|
I don't know if I'm quite ready to completely abandon 160-bit and 192-bit seeds just yet. Maybe I could be convinced. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@apoelstra what holds you back? |
|
Well, first this is marked as draft, and had a lot of outdated comments about the permitted string lengths that were just recently standardized in BIP93. The only thing I have to say about those comments is unshared secrets may use a BIP32 fingerprint as a default ID, a random or user selected ID SHOULD be distinct from all other seeds. Shared strings SHOULD NOT use any identifier derived from the secret as it weakens SSS I still like suggesting may use CRC padding, especially for unshared secrets. I left it out of the "ms" profile for the bip85 app-93 to keep the review and implementation simple. I can update this this week. There have been some very not to spec unreviewed implementations of codex32 generation recently so it's becoming urgent we finish this. |
Closes #64
This is a draft of unshared secrets generation support.
Summary: Updated to discourage weird bitlengths, improve error correction handling. Added details on generation support for codex32 secrets.
Guidance for codex32 share sets generation can come in a later PR as it will depend largely this seed export guidance.
I covered string display and confirmation, from my experience designing these and receiving user feedback.
Confirm section presents two methods depending on keyboard available:
Missing/TBD:
codex32-guiI package for devs to play with.codex32PyPI library, my apologies if I was not supposed to take this name. The implementation is at least as clean as the rust in this repo and passes all BIP93 test vectors.