Repository navigation
Conversation
vibhavgo
added this pull request to stack #280
October 13, 2026 11:41
vibhavgo
force-pushed
the
WCI-926-eddsa-mpcv2-signing-orchestration
branch
from
October 13, 2026 11:47
760eb2f to
b86be22
Compare
vibhavgo
marked this pull request as ready for review
October 13, 2026 12:01
vibhavgo
force-pushed
the
WCI-926-eddsa-mpcv2-signing-orchestration
branch
from
October 14, 2026 10:19
b86be22 to
7d5e64c
Compare
vibhavgo
force-pushed
the
WCI-926-eddsa-mpcv2-signing-orchestration
branch
from
October 15, 2026 18:21
7d5e64c to
dbc2d1c
Compare
Add signAndSendEddsaMPCv2FromTxRequest() to master express eddsa.ts, mirroring the ECDSA MPCv2 orchestrator: instantiate EddsaMPCv2Utils, build round generators via createEddsaMPCv2CustomSigners(), and drive signEddsaMPCv2TssUsingExternalSigner with RequestType.tx. Route EdDSA signing in transactionRequests.ts: wallets with multisigTypeVersion MPCv2 dispatch to the new orchestrator; wallets without it keep the MPCv1 commitment/r/g flow. ECDSA path unchanged. Extend createMPCSendParamsWithCustomSigningFns() in handleSendMany.ts: the SDK's signTransaction dispatches by presence of the custom signing functions, so EdDSA MPCv2 wallets must receive the customEddsaMPCv2SigningRound1/2/3GenerationFunction set; MPCv1 wallets keep commitment/r/g. The helper now takes the wallet and is exported for unit testing. Ticket: WCI-926
vibhavgo
force-pushed
the
WCI-926-eddsa-mpcv2-signing-orchestration
branch
from
October 16, 2026 06:16
dbc2d1c to
b3bd1f8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire the EdDSA MPCv2 signing path through Master Express:
eddsa.ts: newsignAndSendEddsaMPCv2FromTxRequest()mirroring the ECDSA MPCv2 orchestrator — instantiatesEddsaMPCv2Utils, builds round generators viacreateEddsaMPCv2CustomSigners(), and drivessignEddsaMPCv2TssUsingExternalSigner(..., RequestType.tx)transactionRequests.ts: EdDSA branch dispatches to the MPCv2 orchestrator whenwallet.multisigTypeVersion?.() === 'MPCv2'; otherwise the existing MPCv1 commitment/r/g flow; ECDSA path unchangedhandleSendMany.ts:createMPCSendParamsWithCustomSigningFns()now takes the wallet and returns thecustomEddsaMPCv2SigningRound1/2/3GenerationFunctionset for MPCv2 wallets — required because the SDK'ssignTransactiondispatches by presence of the custom functions (MPCv2 wallets given only v1 functions would run the wrong flow); MPCv1 wallets keep commitment/r/g; helper exported for unit testingBackward compatible: wallets without
multisigTypeVersion: 'MPCv2'behave exactly as before.Testing
/client/constantsfixture extended with a real ed25519bitgoEddsaMpcv2PublicKey(the constant the SDK reads for EdDSA MPCv2); AWM round nocks assertcurveType: 'eddsa'via a newexpectedCurveTypebody filter onnockEcdsaMpcv2SigningFlow; signed TxRequest returned and all sign/send nocks consumedtxid/tx; MPCv1 routing test unchangedhandleSendManydispatch unit test: MPCv2 wallet → v2 functions present / v1 absent; MPCv1 wallet → reverseTicket: WCI-926
Linear: https://linear.app/bitgo/issue/WCI-926