Repository navigation
Conversation
vibhavgo
added this pull request to stack #280
October 13, 2026 11:13
vibhavgo
marked this pull request as ready for review
October 13, 2026 11:22
vibhavgo
force-pushed
the
WCI-925-eddsa-mpcv2-custom-signers
branch
from
October 14, 2026 10:19
f89f76a to
8ec3045
Compare
Add createEddsaMPCv2CustomSigners() to master express eddsa.ts, mirroring the ECDSA MPCv2 custom signer pattern. Stateful round generator closures call the existing signMPCv2Round1/2/3() client methods with curveType 'eddsa', capture round 1/2 responses, and forward the encrypted data key, session state and user GPG prv key into the next round. Precondition failures are explicit for out-of-order round calls. Ticket: WCI-925
vibhavgo
force-pushed
the
WCI-925-eddsa-mpcv2-custom-signers
branch
from
October 15, 2026 18:21
8ec3045 to
c84ded3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
createEddsaMPCv2CustomSigners()tosrc/masterBitgoExpress/handlers/eddsa.ts, mirroringcreateEcdsaMPCv2CustomSignersinecdsa.ts:signMPCv2Round1/2/3()client methods withcurveType: 'eddsa'Round 1 must be completed before Round 2,Round 2 must be completed before Round 3Depends on the
curveTypeclient params from WCI-924 (base branch).Testing
New
src/__tests__/api/master/eddsaMpcv2Signing.test.ts(5 tests):curveType: 'eddsa'curveType: 'eddsa'curveType: 'eddsa'Regression: master suites (eddsaMpcv2Signing + ecdsa + eddsa) — 455 passing, 0 failing.
Ticket: WCI-925
Linear: https://linear.app/bitgo/issue/WCI-925