Repository navigation
Conversation
Add optional curveType ('eddsa' | 'ecdsa') to the SignMpcRequest body so
EdDSA MPCv2 callers can explicitly distinguish their requests from ECDSA
MPCv2 while reusing the mpcv2round1/2/3 share types. The field is optional
and unconsumed by the handler (dispatch remains coin-derived), keeping
existing ECDSA callers backward compatible.
Ticket: WCI-923
Add optional curveType ('eddsa' | 'ecdsa') to SignMpcV2Round1/2/3Params
in advancedWalletManagerClient.ts. The existing signMPCv2Round1/2/3()
methods already spread ...params into the request body, so the field is
forwarded without any method changes. Existing ECDSA callers are
unaffected because the field is optional.
Ticket: WCI-924
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two stacked commits implementing WCI-923 and WCI-924 (one commit per ticket):
feat: add curveType to awm mpc sign request(WCI-923) — adds optionalcurveType('eddsa' | 'ecdsa') to theSignMpcRequestbody inadvancedWalletManagerApiSpec.tsso EdDSA MPCv2 callers can explicitly distinguish their requests from ECDSA MPCv2 while reusing thempcv2round1/2/3share types. Optional and unconsumed by the handler (dispatch stays coin-derived), so existing ECDSA callers are backward compatible.feat: add curveType to awm client mpcv2 params(WCI-924) — adds optionalcurveTypetoSignMpcV2Round1/2/3ParamsinadvancedWalletManagerClient.ts. The existingsignMPCv2Round1/2/3()methods already spread...paramsinto the request body, so the field is forwarded without any method changes.Testing
curveType: 'eddsa'accepted on tsolmpcv2round1;curveType: 'ecdsa'accepted on hteth; all pre-existing tests omitcurveType(backward compat).signMpcTransaction.test.ts: 446 passing, 0 failing.advancedWalletManagerClient.test.tsassertscurveType: 'eddsa'present in intercepted round 1/2/3 request bodies when provided and absent when omitted. Master suites (client + ecdsa + eddsa): 450 passing, 0 failing.Ticket: WCI-923, WCI-924
Linear: https://linear.app/bitgo/issue/WCI-923 | https://linear.app/bitgo/issue/WCI-924