Repository navigation
Conversation
Add handleEddsaMPCv2Signing() to ecdsaEddsaSignTransaction.ts, mirroring the ECDSA MPCv2 handler pattern with EddsaMPCv2Utils from sdk-core. Route mpcv2round1/2/3 share types on EdDSA coins to the new handler in signMpcTransaction(); keep MPCv1 commitment/r/g and ECDSA paths unchanged. Crypto and GPG handling stay encapsulated in EddsaMPCv2Utils. Ticket: WCI-922
vibhavgo
marked this pull request as ready for review
October 9, 2026 08:34
vibhavgo
enabled auto-merge
October 9, 2026 08:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
handleEddsaMPCv2Signing()tosrc/advancedWalletManager/handlers/ecdsaEddsaSignTransaction.ts, mirroring the existing ECDSA MPCv2 handler pattern but backed byEddsaMPCv2Utilsfrom@bitgo-beta/sdk-core.mpcv2round1/mpcv2round2/mpcv2round3share types on EdDSA coins (getMPCAlgorithm() === 'eddsa') to the new handler insignMpcTransaction()encryptedDataKey; rounds 2/3 validate the required encrypted state and decrypt the data key before delegating to the SDKEddsaMPCv2UtilsTesting
EdDSA MPCv2 Signing Integration Testsdescribe insignMpcTransaction.test.ts: round 1/2/3 success paths (key-provider nocks + SDK stubs, response field assertions incl.encryptedDataKey) and missing-field validation failures for rounds 2/3signMpcTransaction.test.ts: 444 passing, 0 failing (baseline 439 + 5 new)Ticket: WCI-922
Linear: https://linear.app/bitgo/issue/WCI-922