Skip to content

fix(staking): restore typed subtype payloads - #9733

Closed
Doddanna17 wants to merge 2 commits into
masterfrom
doddannab/SI-1544-bitgojs
Closed

Doddanna17 wants to merge 2 commits into
masterfrom
doddannab/SI-1544-bitgojs

Conversation

@Doddanna17

Copy link
Copy Markdown
Contributor

Summary

  • Restore top-level staking subtype support in BitGoJS.
  • Replace subType?: never with a typed StakingSubType union.
  • Apply the typed subtype to stake and unstake options.
  • Rename the Pox5 subtype to STX_BTC_POX5_BOND.
  • Add a staking request serialization test proving subtype reaches staking-service.

Compatibility

This supports SI-1544 and bitgo-ui PR #12108 by keeping SDK-derived payload typing while preserving subtype on the wire. UI and Retail clients can forward subtype without unsafe casts.

Validation

  • GPG-signed commit.
  • git diff --check passed.
  • Focused tests are currently blocked by pre-existing repository dependency/build issues.

Ticket: SI-1544

@linear-code

linear-code Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

SI-1544

Add typed top-level staking subtypes and verify SDK request serialization for subtype-bearing flows.

Ticket: SI-1544
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@Doddanna17
Doddanna17 force-pushed the doddannab/SI-1544-bitgojs branch from 8ab5ea0 to aaf9e2f Compare September 15, 2026 08:06
Keep pox5-bond wire compatibility while restoring typed subtype payload support for existing staking flows.

Ticket: SI-1544
@Doddanna17 Doddanna17 closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant