docs: add self-contained code review agent skill - #307
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5118ea85bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| When required coverage and validation are complete with no findings, the findings | ||
| section is exactly `No findings.` Otherwise use `Review incomplete.` with specific |
There was a problem hiding this comment.
Don't mark complete reviews incomplete when findings exist
On hosts without a required output schema, a fully validated review that finds any defect fails the only No findings. condition, so this Otherwise branch mandates Review incomplete. and asks for limitations even though coverage is complete. Separate review completeness from the clean/readiness verdict so completed reviews can report findings without falsely claiming a coverage limitation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Implemented in follow-up #308 (commit 9129d31), since #307 was already merged.
The skill now explicitly separates complete reviews with findings, complete reviews without findings, and incomplete reviews with or without findings. Finding a defect no longer forces Review incomplete. or invented limitations. Missing/unresolved/stale coverage or validation evidence still requires an incomplete result, and unresolved defects still block publishing.
Only .github/skills/code-review/SKILL.md changed. Local document/syntax checks and git diff --check passed; the uploaded blob matches the validated bytes. Maven/JAR and live-agent tests were not run. Leaving this thread unresolved while the follow-up is unmerged.
Summary
Add the AdvancedCore counterpart to BenCodez/SimpleAPI#74 as one self-contained file:
.github/skills/code-review/SKILL.md.mvn -B -f AdvancedCore/pom.xml package.Scope
Exactly one added file,
.github/skills/code-review/SKILL.md(262 lines).No scripts, reference files, agent profiles, installers, workflows, application code, model/provider settings, or other repository changes. Existing open non-Dependabot PRs, review-named branches, root contents, and the
.githubtree were inspected before branching frommasterat615a4a846ae377dffb95dbb1bde2cb7e7cc77717. The base was rechecked before publication.The skill needs no companion files and makes no promise that every agent host automatically discovers this location.
Validation
git diff --cached --check.bash -n, not executed. Git checks used a disposable fixture containing the proposed Markdown file, not a full repository clone.fb6446857d940348679b1b169b5e25182072398ematches the locally validated bytes.Kept as a draft. This is not a successful build or independent clean-review claim. No external review was manually requested.
AI disclosure: This pull request was prepared with assistance from ChatGPT.