Tests: a precompiled header for the test executable - #224
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 35 test files include gtest, and 28 include
evaluator.hpp. Header parsing is 40–52% of a test file's compile (clang, measured by compiling each file against a headers-only copy of itself). This adds onetarget_precompile_headersforoscad_eval_tests, covering gtest,evaluator.hpp, the parser API and the shared std headers.Local measurement (clang, macOS, the test executable's objects rebuilt at
-j 4):That's ~20% less CPU but only 2–7% less wall time: the PCH compiles before any test file can start, and the end of the build is dominated by the largest test files.
CI result: small but consistent on Windows, three runs paired against #222's three runs (
/MPonly):/MP/MP+ PCHThat's ~40 s off each Windows CI build. Linux and macOS are within their run-to-run noise. Release wheels don't build the tests, so they're unaffected.
The trade-off: a test file that forgets one of the precompiled includes still compiles here. That only affects test code.
🤖 Generated with Claude Code