Repository navigation
VAPI-4167 fix: final in-call stats lost the call's inbound counters - #28
Merged
Merged
Conversation
The gateway ends a call with a subscribe re-offer that removes its track, so the final read ran after the inbound-rtp stats were gone and logged zeros. Read the snapshot before applying a subscribe re-offer during a call and log it as the final one when the call's stream ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dhelms-bw
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: VAPI-4167
Summary
onremovetrackfires duringsetRemoteDescription, so the "Final in-call stats (call ended)" read ran after the inbound-rtp stats were gone and always logged zero inbound counters,jitter: 0,codec: "unknown".handleSubscribeSdpOffernow reads a snapshot beforesetRemoteDescriptionwhile the in-call trace is running (inside the subscribe mutex), and keeps it only if complete.Test plan
npm test(175 passed)🤖 Generated with Claude Code