Repository navigation
Conversation
Send the buffered diagnostics batch on window pagehide and on visibilitychange to hidden, so a tab close, navigation, or mobile backgrounding does not lose up to 5 minutes of logs. Best effort over the existing websocket. A flush is skipped while the socket is closed so the buffer is kept for a later flush. No-op outside a browser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Guard on addEventListener/removeEventListener, not just window/document - Skip page-exit flushes when the buffer is empty - Make the disconnect test fail if the listeners are not removed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: VAPI-4167
Summary
DiagnosticsBatcheronwindowpagehideand ondocumentvisibilitychangetohidden, sending the batch asdeviceDiagnosticsover the open websocket. Without this, a tab close, navigation, or mobile backgrounding loses up to 5 minutes of buffered logs (including the 10-second in-call stats)._disconnect. No-op whenwindow/documentdo not exist (Node, e.g. the synthetic monitor).beforeunload→disconnect()path usually sends the final batch first; this mainly covers mobile backgrounding and browsers that skipbeforeunload.Test plan
npm test: 172 passed, 6 new (pagehide flushes; hidden flushes; visible does not; no duplicate listeners across opens; nothing after disconnect; logs kept while the socket is closed and sent once it reopens)🤖 Generated with Claude Code